Handle Option[] parameters with no default. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 11 11
Lines 120 120
Branches 10 9 -1
=======================================
Hits 119 119
Misses 1 1
Continue to review full report at Codecov.
|
vpavkin
requested changes
Mar 4, 2019
| @@ -34,7 +34,11 @@ private[magnolia] object MagnoliaDecoder { | |||
| val keyCursor = c.downField(key) | |||
| keyCursor.focus match { | |||
| case Some(json) => json.as[p.PType](p.typeclass) | |||
| case None => p.default.toRight(DecodingFailure("Attempt to decode value on failed cursor", keyCursor.history)) | |||
| case None => p.default.map { default => Right(default) }.getOrElse { | |||
There was a problem hiding this comment.
good, I would just use fold:
p.default.fold(p.typeclass.tryDecode(keyCursor))(Right(_))
There was a problem hiding this comment.
Sure! I've never liked Option.fold because it puts the None case first, which is not natural to me, but happy to make the change.
|
RFAL, thanks! |
|
Thanks, @adampauls ! |
|
@adampauls Pushed 0.5.0 release with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circe permits case class parameters of type
Option[T]with no default specified to still be decoded (toNone) when the parameter is missing. This PR brings circe-magnolia in line with this behavior.