Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wpc implementation #139

Merged
merged 66 commits into from
Nov 9, 2019
Merged

Feature/wpc implementation #139

merged 66 commits into from
Nov 9, 2019

Conversation

neophob
Copy link
Contributor

@neophob neophob commented Nov 8, 2019

Implements #124 , details:

Implemented:

  • emuStep(howManyMsPassed)
  • wpc-emu websocket decoupled - we can use the api for the main thread but there is also an API for - within the webworker
  • typescript exports implemented for all api's
  • write adapter between "VISUAL PINMAME COM OBJECT" and WPC-EMU (see https://github.com/vpdb/vpx-js/blob/feature/wpc/lib/scripting/objects/API.md). VpmController needs to expose this api and forward this to wpc emu
  • create diff notification (send only changed Lamps, Solenoid, GI, LED)
  • option to exclude "expensive state objects" like RAM, VideoRAM
  • WPC-EMU, add function to set or clear a switch (only toggle was supported)
  • grab rom from vpdb.io

Next steps, see #138

@neophob neophob requested a review from freezy November 8, 2019 21:14
@codecov
Copy link

codecov bot commented Nov 8, 2019

Codecov Report

Merging #139 into master will decrease coverage by 0.1%.
The diff coverage is 78.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #139     +/-   ##
========================================
- Coverage    90.9%   90.8%   -<.1%     
========================================
  Files         266     270      +4     
  Lines       13951   14230    +279     
  Branches     1636    1664     +28     
========================================
+ Hits        12671   12911    +240     
- Misses        787     812     +25     
- Partials      493     507     +14
Impacted Files Coverage Δ
lib/vpt/light/light-updater.ts 66.7% <0%> (-13.3%) ⬇️
lib/game/player-physics.ts 86.4% <0%> (-0.3%) ⬇️
lib/game/player.ts 86.6% <0%> (-6.7%) ⬇️
lib/render/threejs/three-material-generator.ts 57.7% <100%> (ø) ⬆️
lib/render/threejs/three-light-generator.ts 52.8% <29.5%> (+10.3%) ⬆️
lib/scripting/objects/pinball-backend/wpc-emu.ts 57.7% <57.7%> (ø)
...b/scripting/objects/pinball-backend/rom-fetcher.ts 86.7% <86.7%> (ø)
...cripting/objects/pinball-backend/emulator-state.ts 88.3% <88.3%> (ø)
...ripting/objects/pinball-backend/caching-service.ts 93.6% <93.6%> (ø)
lib/scripting/objects/vpm-controller.ts 93.9% <93.7%> (-6.1%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d20ea...d2d0e1a. Read the comment docs.

Copy link
Member

@freezy freezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR. Making progress fast here :)

I'll look into why the lights stay dark now.

lib/scripting/objects/pinball-backend/caching-service.ts Outdated Show resolved Hide resolved
lib/scripting/objects/pinball-backend/caching-service.ts Outdated Show resolved Hide resolved
lib/scripting/objects/pinball-backend/caching-service.ts Outdated Show resolved Hide resolved
lib/scripting/objects/pinball-backend/wpc-emu.ts Outdated Show resolved Hide resolved
lib/scripting/objects/pinball-backend/wpc-emu.ts Outdated Show resolved Hide resolved
lib/scripting/objects/vpm-controller.ts Show resolved Hide resolved
lib/scripting/objects/vpm-controller.ts Show resolved Hide resolved
lib/scripting/objects/vpm-controller.ts Show resolved Hide resolved
@neophob neophob merged commit 843c474 into master Nov 9, 2019
@neophob neophob deleted the feature/wpc-implementation branch November 9, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants