-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/wpc implementation #139
Conversation
- update rom fetcher
- add debug info when ChangedLamps and Lamp call is made
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
========================================
- Coverage 90.9% 90.8% -<.1%
========================================
Files 266 270 +4
Lines 13951 14230 +279
Branches 1636 1664 +28
========================================
+ Hits 12671 12911 +240
- Misses 787 812 +25
- Partials 493 507 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR. Making progress fast here :)
I'll look into why the lights stay dark now.
Implements #124 , details:
Implemented:
Next steps, see #138