Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flags set method for tansfer #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wang0618
Copy link

This PR adds a setFlags() method to USBTransfer to set the libusb_transfer.flags

@vpelletier
Copy link
Owner

My apologies, I completely missed the bug report you opened as well as this merge request.

I agree that flags need to be exposed.

This said, of the currently-defined 4 flags, two would cause crashes, so the code must prevent the user from setting those. This would probably best be done by only allowing the known-safe flags, raising if the caller tries to set anything else.

I also think the currently-set flags should be exposed, probably by adding a getFlags method. I wonder what return type would be best.

Could you implement such changes and update this merge request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants