Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several changes for 3D Tiles api #213

Merged
merged 47 commits into from
Jan 24, 2024

Conversation

bertt
Copy link
Contributor

@bertt bertt commented Jan 4, 2024

. IMeshFeatureIDInfo, FeatureIdBuilder moved to new file

. Renamed method SetValues1D -> SetValues (because most frequently used)

  • Renamed method SetValues2D -> SetArrayValues

. Changed FeatureIDBuilder constructor to

FeatureIDBuilder(int featureCount, OneOf<int, Texture>? attributeOrTexture = null, PropertyTable propertyTable = null, IReadOnlyList<int> channels = null, string label = null, int? nullFeatureId = null)

. Changed method AddMeshFeatureIds(this MeshPrimitive primitive, params (IMeshFeatureIDInfo fid, Texture tex, IReadOnlyList channels)[] featureIds)

to AddMeshFeatureIds(this MeshPrimitive primitive, params IMeshFeatureIDInfo[] fids)

. Improve support for array types (determine automatically if the array is fixed length or not)

. added type checking of metadata values to the schema

. fixed enums (must use short type)

. Tested all Cesium tests https://github.com/CesiumGS/3d-tiles-validator/tree/main/specs/data/gltfExtensions

. Added README.md with sample code

NOT supported now:

. external schema (using a json file) support;

. reading/writing/validating properties min, max, offset and scale.

@bertt bertt marked this pull request as draft January 4, 2024 20:56
@bertt bertt changed the title change feature Id constructor (adding nullfeatureId) + small changes Several changes for 3D Tiles api Jan 11, 2024
@bertt bertt marked this pull request as ready for review January 11, 2024 15:11
@bertt bertt marked this pull request as draft January 11, 2024 17:43
Copy link
Owner

@vpenades vpenades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other that that, everything else looks fine.

src/SharpGLTF.Core/Schema2/_Extensions.Nullables.cs Outdated Show resolved Hide resolved
@bertt bertt marked this pull request as ready for review January 21, 2024 21:34
@vpenades vpenades merged commit 6a7a68b into vpenades:master Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants