-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several changes for 3D Tiles api #213
Merged
vpenades
merged 47 commits into
vpenades:master
from
bertt:change_feature_id_constructor
Jan 24, 2024
Merged
Several changes for 3D Tiles api #213
vpenades
merged 47 commits into
vpenades:master
from
bertt:change_feature_id_constructor
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertt
commented
Jan 4, 2024
bertt
changed the title
change feature Id constructor (adding nullfeatureId) + small changes
Several changes for 3D Tiles api
Jan 11, 2024
bertt
commented
Jan 11, 2024
vpenades
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other that that, everything else looks fine.
… to validate them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
. IMeshFeatureIDInfo, FeatureIdBuilder moved to new file
. Renamed method SetValues1D -> SetValues (because most frequently used)
. Changed FeatureIDBuilder constructor to
. Changed method AddMeshFeatureIds(this MeshPrimitive primitive, params (IMeshFeatureIDInfo fid, Texture tex, IReadOnlyList channels)[] featureIds)
to AddMeshFeatureIds(this MeshPrimitive primitive, params IMeshFeatureIDInfo[] fids)
. Improve support for array types (determine automatically if the array is fixed length or not)
. added type checking of metadata values to the schema
. fixed enums (must use short type)
. Tested all Cesium tests https://github.com/CesiumGS/3d-tiles-validator/tree/main/specs/data/gltfExtensions
. Added README.md with sample code
NOT supported now:
. external schema (using a json file) support;
. reading/writing/validating properties min, max, offset and scale.