Increment package version correctly #21
Conversation
| @@ -196,24 +196,20 @@ fn (manifest PkgManifest) manipulate_version(@type string, state string) string | |||
| else {} | |||
| } | |||
|
|
|||
| if selected_idx > ver_arr.len { | |||
| for selected_idx > ver_arr.len-1 { | |||
There was a problem hiding this comment.
Tbh, I don't like this solution. I'd go with displaying an error, if the version does not follow semver format (ver_arr.len is not equal 3 for now). This is preferrable way, as we are supposed to work with semver format in this case.
Alternatively, we can normalize the version to semver (where we have only three version fields). But I'm not sure if it's a proper way to handle invalid version formats.
There was a problem hiding this comment.
Yeah... that's when the time semver libraries for V haven't existed yet. Lets merge this for now. I'll integrate your semver library later
| @@ -196,24 +196,20 @@ fn (manifest PkgManifest) manipulate_version(@type string, state string) string | |||
| else {} | |||
| } | |||
|
|
|||
| if selected_idx > ver_arr.len { | |||
| for selected_idx > ver_arr.len-1 { | |||
There was a problem hiding this comment.
Yeah... that's when the time semver libraries for V haven't existed yet. Lets merge this for now. I'll integrate your semver library later
Fixes #20.