Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove InterpretedSimplifier, long dead #170

Merged
merged 1 commit into from
Nov 11, 2020
Merged

remove InterpretedSimplifier, long dead #170

merged 1 commit into from
Nov 11, 2020

Conversation

MichaelRawson
Copy link
Contributor

See issue #157 - InterpretedSimplifier was commented out circa 2011 and not revived since.

@selig
Copy link
Contributor

selig commented Nov 11, 2020

joe-hauns will we use any of this?

@MichaelRawson
Copy link
Contributor Author

@joe-hauns ^^

@joe-hauns
Copy link
Contributor

I had a look at it at some point, and made some notes what's going on there, and I think it's not worth the effort trying to revive it.
The plans I have are somewhat similar to but more general to what's going on in there. So I think it's better to reimplement it with the more general thing in mind.

@selig selig merged commit 71bf1f4 into master Nov 11, 2020
@MichaelRawson MichaelRawson deleted the michael-remove-interpreted-simplifier branch November 11, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelRawson @selig @joe-hauns