remove code commented out or not built #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quickbeam123 - the commit sequence is designed to be cherry-picked from if people want some of these. :-) |
|
I think we should look through these in a little detail. For example, the files in the CTFwSubsAndRes commit were removed with the plan to "definitely" put them back when we fix code trees. |
|
@selig - agreed, hence the file-per-commit. CTFw has been out since 2016 so I figured we don't miss it, but by all means let me know if I can reanimate something. |
MichaelRawson
force-pushed
the
michael-remove-unused-files
branch
3 times, most recently
from
46c03a8
to
77be0c7
Compare
MichaelRawson
changed the title
MichaelRawson
force-pushed
the
michael-remove-unused-files
branch
from
9b24b1d
to
c9db646
Compare
MichaelRawson
force-pushed
the
michael-remove-unused-files
branch
from
c9db646
to
f302060
Compare
|
I think people prefer these removed one-by-one, and this needs rebasing anyway. Let's can it and do them individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #157. Some files are commented out (permanently) in the build system: this removes them. Bonus: remove some redundant includes.
EDIT: also remove things guarded by
GNUMPas it doesn't compile.