Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Location of trace norm should be changed #167

Closed
vprusso opened this issue Jun 3, 2023 · 0 comments · Fixed by #172
Closed

Refactor: Location of trace norm should be changed #167

vprusso opened this issue Jun 3, 2023 · 0 comments · Fixed by #172
Labels

Comments

@vprusso
Copy link
Owner

vprusso commented Jun 3, 2023

At present the trace_norm.py file is located in the state_metrics/ directory. Generally, the other metrics that are contained within the state_metrics/ directory are some type of distance measure between one state and another. The trace norm function breaks this pattern and is really just a measure of the state itself (instead of being a measure of a state against another state).

It may be more appropriate, therefore, to move the trace_norm functionality inside of the matrix_props/ directory. This would also seem to make somewhat more categorical sense, as sk_norm.py is contained in matrix_props/ as well.

@purva-thakre purva-thakre mentioned this issue Jun 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant