Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Trace Norm #172

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Move Trace Norm #172

merged 6 commits into from
Jun 5, 2023

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Jun 4, 2023 •
edited
Loading

Description

Fixes #167

Todos

Moved trace_norm, fixed import paths & updated docs.

Questions

N/A

Status

  • Ready to go

@purva-thakre purva-thakre marked this pull request as ready for review June 4, 2023 16:22
@purva-thakre
Copy link
Collaborator Author

purva-thakre commented Jun 4, 2023 •
edited
Loading

Same as what was said in #165, autodocsummary is adding more files than expected.

Here, only wanted docs/_autosummary/toqito.matrix_props.trace_norm.rst.

Deleted all autosummary files

@vprusso
Copy link
Owner

vprusso commented Jun 5, 2023

Hi @purva-thakre. Thanks for tackling this one!

It might be worthwhile to mention that when #157 goes in, I imagine some parts of the PR may have to be (slightly) updated. Just a heads up!

vprusso
vprusso reviewed Jun 5, 2023
View reviewed changes
toqito/state_metrics/helstrom_holevo.py Outdated Show resolved Hide resolved
toqito/state_metrics/trace_distance.py Outdated Show resolved Hide resolved
toqito/state_props/is_separable.py Outdated Show resolved Hide resolved
@vprusso
Copy link
Owner

vprusso commented Jun 5, 2023

This looks great, @purva-thakre! Just a heads up that there might be a change or two when you rebase from the changes in this MR:
#157

Let me know if I can help out with that if need be!

@purva-thakre purva-thakre marked this pull request as draft June 5, 2023 16:21
@purva-thakre
Copy link
Collaborator Author

This looks great, @purva-thakre! Just a heads up that there might be a change or two when you rebase from the changes in this MR: #157

Let me know if I can help out with that if need be!

@vprusso Thanks for the offer! I always forget I need to force push after a rebase & then panic. This PR should be good now.

@purva-thakre purva-thakre marked this pull request as ready for review June 5, 2023 17:24
@vprusso
Copy link
Owner

vprusso commented Jun 5, 2023

Excellent! Looks good to me! 🚀

Thanks again, @purva-thakre !

@vprusso vprusso merged commit 53ff701 into vprusso:master Jun 5, 2023
@purva-thakre purva-thakre deleted the refactor_trace_norm branch June 5, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprusso vprusso vprusso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: Location of trace norm should be changed
2 participants
@purva-thakre @vprusso