Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded files #195

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Remove unneeded files #195

merged 1 commit into from
Oct 15, 2023

Conversation

purva-thakre
Copy link
Collaborator

@purva-thakre purva-thakre commented Oct 14, 2023 •
edited
Loading

Description

As discussed previously, this PR removes files that are no longer needed.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • N/A

Questions

  • Checked that the documentation build correctly and that all tests pass locally. Any other checks missed here?
  • Why does codecov/project mark a PR build as failing until Github Actions runs all 3 jobs?

Status

  • Ready to go

vprusso
vprusso approved these changes Oct 15, 2023
View reviewed changes
Copy link
Owner

@vprusso vprusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Merge when ready, @purva-thakre !

@purva-thakre purva-thakre merged commit df6b2fd into vprusso:master Oct 15, 2023
@purva-thakre purva-thakre deleted the remove_files branch October 15, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprusso vprusso vprusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purva-thakre @vprusso