Update pytest coverage for CB trace norm #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #234 +/- ##
========================================
+ Coverage 96.4% 96.5% +0.1%
========================================
Files 146 146
Lines 2956 2956
Branches 728 728
========================================
+ Hits 2851 2854 +3
+ Misses 61 59 -2
+ Partials 44 43 -1 ☔ View full report in Codecov by Sentry. |
purva-thakre
commented
Nov 14, 2023
vprusso
approved these changes
Nov 14, 2023
|
|
||
|
|
||
| def test_cb_trace_norm_unitaries_channel(): | ||
| """The diamond norm of phi = id- U id U* is the diameter of the smallest circle that contains the eigenvalues of U.""" | ||
| """The diamond norm of phi = id- U id U* is the diameter of the smallest circle |
There was a problem hiding this comment.
I wonder if the linter is over-aggressively making new lines here when it shouldn't be?
There was a problem hiding this comment.
Probably due to us having different configuration files with incompatible line lengths.
vprusso
pushed a commit
that referenced
this pull request
Nov 15, 2023
* add missing test * undo docstring change: linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #233
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status