Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-local games example #874

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

Shivansh20128
Copy link
Contributor

@Shivansh20128 Shivansh20128 commented Oct 24, 2024

Description

This PR resolves the flacky non-local games docstring example. The fix is the same as the earlier fix in #613.
#Resolves #873.

Changes

  • Added multiple runs in the non-local games example to prevent getting suboptimal solution.

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.9%. Comparing base (06b0922) to head (edce66f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #874   +/-   ##
======================================
  Coverage    97.9%   97.9%           
======================================
  Files         165     165           
  Lines        3253    3253           
  Branches      713     713           
======================================
  Hits         3185    3185           
  Misses         44      44           
  Partials       24      24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso
Copy link
Owner

vprusso commented Oct 24, 2024

This LGTM! Nice fix, @Shivansh20128 !

@vprusso vprusso merged commit 95f1809 into vprusso:master Oct 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky non-local games doctest
2 participants