Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(group): add "banned" to GroupMembershipStatus #296

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

ttshivers
Copy link
Contributor

Add "banned" to GroupMembershipStatus. This shows up on /groups/{groupId}/bans.

Add "banned" to GroupMembershipStatus. This shows up on
`/groups/{groupId}/bans`.
@ariesclark ariesclark merged commit 821a701 into vrchatapi:main Mar 24, 2024
6 checks passed
@ttshivers ttshivers deleted the membershipStatus-banned branch March 24, 2024 00:13
@ariesclark
Copy link
Member

Hi, we appropriate your contributions!

We also have a testing repository that should be keeping track of changes in the API, if you'd like, you could take a look. For example: here is the getUser response, with a few undocumented properties marked out. The repository itself has a lot of missing coverage, like groups not having any tests at all.

@ttshivers
Copy link
Contributor Author

Hi, we appropriate your contributions!

We also have a testing repository that should be keeping track of changes in the API, if you'd like, you could take a look. For example: here is the getUser response, with a few undocumented properties marked out. The repository itself has a lot of missing coverage, like groups not having any tests at all.

Here is an attempt at a basic test to start vrchatapi/specification-test#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants