Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storeId #400

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

jellejurre
Copy link
Contributor

No description provided.

@ariesclark
Copy link
Member

ariesclark commented Oct 8, 2024

If the property never occurs, I would prefer to remove it entirely to avoid having properties that are "lost to time" in the schema.

@Rexios80
Copy link
Collaborator

Rexios80 commented Oct 8, 2024

Getting this in the Dart SDK

DioException (DioException [unknown]: null
Error: CheckedFromJsonException
Could not create `LimitedWorld`.
There is a problem with "storeId".
Required keys are missing: storeId.)

@jellejurre
Copy link
Contributor Author

Fair enough, if they come back I suppose we'll just readd them

@jellejurre jellejurre changed the title Make storeId optional as they seem to have removed it? Remove storeId Oct 8, 2024
@jellejurre
Copy link
Contributor Author

Getting this in the Dart SDK

DioException (DioException [unknown]: null
Error: CheckedFromJsonException
Could not create `LimitedWorld`.
There is a problem with "storeId".
Required keys are missing: storeId.)

This is the result before this pr, I added storeId as a required argument because it seemed to always be there, but then they removed it, so now you get "required arguement is missing", hence we're removing it again

@ariesclark ariesclark enabled auto-merge (squash) October 8, 2024 20:15
@ariesclark ariesclark merged commit b9eaff9 into vrchatapi:main Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants