User- and file-related endpoints #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GET /auth/user/favoritelimits`
`GET /analysis/{fileId}/{versionId}`
`GET /analysis/{fileId}/{versionId}/security`
`GET /analysis/{fileId}/{versionId}/standard`
`GET /users/{userId}/feedback`
`GET /userNotes`
`POST /userNotes`
`GET /userNotes/{userNoteId}`
|
Looks good Do you think you could add relevant tests to the spec tests for this one as well? |
|
Ofc, wanted to make sure this was all ok before doing that |
From Nayir in Discord:
|
Hackebein
reviewed
Nov 20, 2024
Co-authored-by: Lars Olzem <hackebein@gmail.com>
|
@jellejurre None of the responses I get contain the |
Hackebein
reviewed
Nov 20, 2024
|
yeah I noticed that as well, but it definitely got added once. Don't know what causes it to get added, but making it optional for now |
|
LGTM. You okay with my changes here and in the spec tests? @VinyarionHyarmendacil |
|
ye👍 |
jellejurre
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET /auth/user/favoritelimitsGET /analysis/{fileId}/{versionId}GET /analysis/{fileId}/{versionId}/securityGET /analysis/{fileId}/{versionId}/standardGET /users/{userId}/feedbackGET /userNotesPOST /userNotesGET /userNotes/{userNoteId}