Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Importer] 負のスケール(ミラーリング)を含む行列の TRS 分解に失敗する #1078

Closed
ousttrue opened this issue Jun 29, 2021 · 2 comments
Closed

[Importer] 負のスケール(ミラーリング)を含む行列の TRS 分解に失敗する #1078

ousttrue opened this issue Jun 29, 2021 · 2 comments
Labels
importer
Milestone
v0.999

Comments

@ousttrue
Copy link
Contributor

ousttrue commented Jun 29, 2021 •
edited
Loading

UniVRM/Assets/UniGLTF/Runtime/UniGLTF/IO/NodeImporter.cs

Lines 52 to 55 in 9339733

var m = UnityExtensions.MatrixFromArray(node.matrix);
go.transform.localRotation = m.ExtractRotation();
go.transform.localPosition = m.ExtractPosition();
go.transform.localScale = m.ExtractScale();

この辺り。改善が必用。
@ousttrue
Copy link
Contributor Author

行列式が負の時、Xミラー試行、Zミラー試行、Yミラー試行

というロジックで例外処理する方針

@ousttrue ousttrue mentioned this issue Jul 1, 2021
Merged
@ousttrue ousttrue added this to the v0.81.0 milestone Aug 11, 2021
@ousttrue ousttrue modified the milestones: v0.81, v0.82 Aug 24, 2021
@ousttrue ousttrue modified the milestones: v0.82, v0.83 Sep 1, 2021
@ousttrue ousttrue modified the milestones: v0.83, v0.999 Sep 8, 2021
@ousttrue
Copy link
Contributor Author

ousttrue commented Oct 1, 2021

#1087 で X軸ミラー決め打ちで妥協

@ousttrue ousttrue closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
importer
Projects
None yet
Milestone
v0.999
Development

No branches or pull requests
1 participant
@ousttrue