Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/export divided test #1010

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jun 7, 2021

VERTEX BUFFER 分割時に BlendShape で発生

@ousttrue ousttrue requested a review from Santarh June 7, 2021 10:44
@ousttrue ousttrue added this to the v0.76 milestone Jun 7, 2021
@@ -44,7 +44,9 @@ public static gltfMorphTarget Export(glTF gltf, int gltfBuffer, Vector3[] positi
var positionAccessorIndex = -1;
if (sparseIndices.Length > 0)
{
#if VRM_DEVELOP
Debug.LogFormat("Sparse {0}/{1}", sparseIndices.Length, positions.Length);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@@ -89,7 +89,7 @@ public static class MeshExporter_DividedVertexBuffer
// blendShape(morph target)
for (int j = 0; j < mesh.blendShapeCount; ++j)
{
var blendShape = new MeshExportUtil.BlendShapeBuffer(indices.Length);
var blendShape = new MeshExportUtil.BlendShapeBuffer(usedIndices.Count);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど

@ousttrue ousttrue merged commit be4f06f into vrm-c:master Jun 7, 2021
@ousttrue ousttrue deleted the fix/export_divided_test branch October 27, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants