Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextureDeserializer can await. #1074

Merged
merged 2 commits into from
Jun 25, 2021
Merged

TextureDeserializer can await. #1074

merged 2 commits into from
Jun 25, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Jun 24, 2021

No description provided.

@Santarh Santarh requested a review from ousttrue June 24, 2021 13:04
Santarh
Santarh commented Jun 24, 2021
View reviewed changes
Assets/VRMShaders/GLTF/IO/Runtime/ITextureDeserializer.cs
/// <returns></returns>
Task<Texture2D> LoadTextureAsync(byte[] imageData, bool useMipmap, ColorSpace colorSpace);
Task<Texture2D> LoadTextureAsync(byte[] imageData, bool useMipmap, ColorSpace colorSpace, IAwaitCaller awaitCaller);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

主目的

ousttrue
ousttrue approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。

IAwaitCller の目的は、

  • UnitTest でデッドロックしない(同期実行)
  • アプリからのRuntime時はそれなりに非同期実行
    • 重くてUnityにアクセスしないタスクをスレッドに乗せる
    • 処理を返して、次のフレームに再開する

です。

@ousttrue ousttrue merged commit 7b3303b into vrm-c:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santarh @ousttrue