Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress shader compile errors when URP is not imported. #2344

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Suppress shader compile errors when URP is not imported. #2344

merged 2 commits into from
Jul 4, 2024

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Jul 4, 2024

プロジェクトに URP が未導入の場合に MToon10 の URP 版シェーダがコンパイルエラーを Log に出力するのを抑制。

Unity 2021 からの機能を利用
https://docs.unity3d.com/2021.3/Documentation/Manual/SL-PackageRequirements.html

@Santarh Santarh requested a review from ousttrue July 4, 2024 07:03
ousttrue
ousttrue approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ousttrue
Copy link
Contributor

ousttrue commented Jul 4, 2024

#2065 ?

@Santarh
Copy link
Contributor Author

Santarh commented Jul 4, 2024

Issue ありましたね！

@Santarh
Copy link
Contributor Author

Santarh commented Jul 4, 2024

Fixed #2065

@Santarh Santarh merged commit 8b1dd96 into vrm-c:master Jul 4, 2024
1 of 2 checks passed
@Santarh Santarh deleted the suppressShaderCompileError branch July 4, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
Non breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santarh @ousttrue