生成シリアライザをデフォルトにする #564
Merged
生成シリアライザをデフォルトにする #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alpha cutoff is supported only for 'MASK' alpha mode.
|
シリアライザーやデシリアライザーの変更は事故る確率が他の変更よりも高いと思っているため、こちらがマージされてもすぐにリリースせず一週間程度寝かせる期間を置いてもらえると嬉しいです。 |
hiroj
approved these changes
Sep 28, 2020
|
10/5 の週にリリースする予定です。 |
|
対応ありがとうございます！ |
|
validator にひっかかるデータを作りました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#553
#490
https://github.com/KhronosGroup/glTF-Validator/blob/1be41dd1acdfe21ee9e577577bc2183e6861345a/ISSUES.md
BUFFER_VIEW_TARGET_OVERRIDEACCESSOR_MAX_MISMATCHは、validator の方に 修正が要ると思う。
https://github.com/KhronosGroup/glTF-Sample-Models
に該当するサンプルを送って修正依頼を試みる。
(違うタイプの sparse しかサンプルが無い )
での動作を確認した。