Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0]ジェネレーターの生成コード(Format)からUniJSON, UniGLTF依存を除去 #886

Merged

Conversation

ousttrue
Copy link
Contributor

GltfExtension の JsonSchema から生成した Format.cs から、型依存を取り除いた

@Santarh Santarh self-requested a review May 6, 2021 07:26
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。コンフリクト解決お願いします!

@@ -178,8 +154,7 @@ public static void Write(TextWriter w, JsonSchemaSource root, string rootName)
w.Write($@"// This file is generated from JsonSchema. Don't modify this source code.
using System;
using System.Collections.Generic;
using UniGLTF;
using UniJSON;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@ousttrue ousttrue force-pushed the feature10/generated_format_dependency branch from 359ae9c to 871f57e Compare May 6, 2021 07:32
@Santarh Santarh self-requested a review May 6, 2021 07:32
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいんじゃないでしょうか

@ousttrue ousttrue merged commit 36d67c4 into vrm-c:master May 6, 2021
@ousttrue ousttrue deleted the feature10/generated_format_dependency branch May 17, 2021 05:21
@ousttrue ousttrue added the 1.0 label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants