Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrm1 の Extract 先を vrm0 と別になるように修正。 #937

Merged
merged 1 commit into from
May 10, 2021

Conversation

ousttrue
Copy link
Contributor

  • VRM1の asset が VRM0 と別フォルダになるように修正(migrateしたときに混在してしまう)
  • VRM10ExpressionAvatar が MonoBehaviour になって Extract対象から外れたことの修正

@ousttrue ousttrue requested a review from Santarh May 10, 2021 06:34
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指針はよさそう、疑問点は 1

EditorMaterial.OnGUI(m_importer, m_parser, Vrm10TextureEnumerator.EnumerateAllTexturesDistinct);
EditorMaterial.OnGUI(m_importer, m_parser, Vrm10TextureEnumerator.EnumerateAllTexturesDistinct,
assetPath => $"{Path.GetFileNameWithoutExtension(assetPath)}.vrm1.Textures",
assetPath => $"{Path.GetFileNameWithoutExtension(assetPath)}.vrm1.Materials");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

. って OS によっては(Windows とか)マズくないですか?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よく考えたら大丈夫か

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

フォルダ名なので、たぶん大丈夫

@ousttrue ousttrue merged commit 2a154c9 into vrm-c:master May 10, 2021
@ousttrue ousttrue deleted the fix10/vrm1_extract_dir branch May 17, 2021 05:21
@ousttrue ousttrue added the 1.0 label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants