Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GL.sRGBWrite #941

Merged
merged 1 commit into from
May 13, 2021
Merged

Remove GL.sRGBWrite #941

merged 1 commit into from
May 13, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented May 13, 2021

  • GL.sRGBWrite はそもそも Linear パイプラインの都合を捻じ曲げたいときの最終手段ゆえ、できるかぎり使うべきではない
  • いまの使用箇所ではそもそも GL.sRGBWrite が機能していないため
    • sRGB のテクスチャに書き込むときは GL.sRGBWrite = true; になっている
    • Linear のテクスチャに書き込むときは GL.sRGBWrite = false; になっている

@Santarh Santarh requested a review from ousttrue May 13, 2021 08:45
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unity-5.6 の時は必要だったのかも?しれない。よくわからない。

@ousttrue ousttrue merged commit d9dcd06 into vrm-c:master May 13, 2021
@ousttrue ousttrue added the colorspace gamma(sRGB) / Linear label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
colorspace gamma(sRGB) / Linear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants