[1.0] constraitn の実装 #952
Merged
[1.0] constraitn の実装 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ousttrue
force-pushed
the
feature10/impl_constraint
branch
from
b363c27 to
f1e0a2f
Compare
|
rebase |
Santarh
approved these changes
May 18, 2021
| { | ||
| } | ||
|
|
||
| public Matrix4x4 TRS(float s) => Matrix4x4.TRS(Translation, Rotation, new Vector3(s, s, s)); |
| var localPosition = transform.worldToLocalMatrix.MultiplyPoint(Source.position); | ||
| // var (yaw, pitch) = CalcYawPitch(m_coords, localPosition); | ||
| var zAxis = (Source.position - transform.position).normalized; | ||
| var xAxis = Vector3.Cross(Vector3.up, zAxis); |
There was a problem hiding this comment.
World Up に依存するのはどうしようもない
これ以上綺麗な定義があるか？というと、おそらくない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
を実装した。
という継承