Refactoring Serializing Textures #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
commented
May 20, 2021
| using UnityEditor; | ||
| using UnityEngine; | ||
| using ColorSpace = UniGLTF.ColorSpace; | ||
|
|
||
| namespace VRMShaders | ||
| { | ||
| public static class AssetTextureUtil | ||
| public sealed class EditorTextureSerializer : ITextureSerializer |
There was a problem hiding this comment.
EditorTextureSerializer
ousttrue
reviewed
May 20, 2021
| using UnityEngine; | ||
|
|
||
| namespace UniGLTF | ||
| { |
There was a problem hiding this comment.
関数が２つになったので、Delegate から interface に拡張
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Texture を具体的に
byte[]に切り出すメソッド群を切り出してITextureSerializerを定義。EditorTextureSerializerとRuntimeTextureSerializerを定義。