Even if the texture instance is the same, if the color space required by the glTF specification is different, it will be output as a different texture. #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
commented
May 20, 2021
| /// | ||
| /// glTF 拡張で Texture の用途を増やす必要がある場合は、この interface を継承して実装すればよい。 | ||
| /// </summary> | ||
| public interface ITextureExporter |
There was a problem hiding this comment.
インタフェース化。glTF 拡張を実装する際にテクスチャの用途が増えたとしても、容易に拡張できる。
Santarh
commented
May 20, 2021
| // sRGB テクスチャとして出力 | ||
| Srgb, | ||
| // Linear テクスチャとして出力 | ||
| Linear, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
たとえ同じ Texture インスタンスであっても、glTF 仕様が要求する色空間が異なれば別のテクスチャとして出力する。
たとえば Albedo と Normal の 2 つの Property に同じ Texture が設定されているとする。
このとき、Albedo は sRGB 色空間のテクスチャとして、Normal は Linear テクスチャとして出力されなければならない。
現状では、先に処理したほうのキャッシュを参照してしまう。
あと、そのためのリファクタリング。