Extension implementation can inject texture loading strategy to ImporterContext #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
commented
May 27, 2021
| public ImporterContext( | ||
| GltfParser parser, | ||
| IReadOnlyDictionary<SubAssetKey, UnityEngine.Object> externalObjectMap = null, | ||
| ITextureDeserializer textureDeserializer = null) |
Santarh
commented
May 27, 2021
| /// <param name="useMipmap">Texture2D の mipmap が生成されるべきか否か</param> | ||
| /// <param name="colorSpace">Texture2D の色空間</param> | ||
| /// <returns></returns> | ||
| Task<Texture2D> LoadTextureAsync(byte[] imageData, bool useMipmap, ColorSpace colorSpace); |
Santarh
commented
May 27, 2021
| // ConvertToNormalValueFromRawColorWhenCompressionIsRequired | ||
| public static Texture2D Import(Texture2D texture) | ||
| { | ||
| return TextureConverter.CopyTexture(texture, ColorSpace.Linear, false, Encoder); |
ousttrue
reviewed
May 27, 2021
| // > contrary to Unity’s usual convention of using Y as “up” | ||
| // https://docs.unity3d.com/2018.4/Documentation/Manual/StandardShaderMaterialParameterNormalMap.html | ||
| var data0 = await texDesc.Index0(); | ||
| var rawTexture = await _textureDeserializer.LoadTextureAsync(data0, texDesc.Sampler.EnableMipMap, ColorSpace.Linear); |
There was a problem hiding this comment.
_textureDeserializer.LoadTextureAsync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITextureDeserializerImporterContextcan be injectedITextureDeserializer