Feature/animation extract #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Jun 1, 2021
ousttrue
commented
- AnimationClip の Extract を実装
- IAnimationImporter を単純化。必要に応じて再拡張
ousttrue
force-pushed
the
feature/animation_extract
branch
from
22183b7 to
541ece5
Compare
|
rebase しました。 |
Santarh
approved these changes
Jun 3, 2021
|
|
||
| namespace UniGLTF | ||
| { | ||
| public interface IAnimationImporter | ||
| { | ||
| List<AnimationClip> Import(glTF gltf, GameObject root, List<Transform> nodes, Axes invertAxis); | ||
| AnimationClip Import(glTF gltf, int i, Axes invertAxis); |
| #endif | ||
| break; | ||
| } | ||
| animation.name = string.Format("{0}({1})", originalName, j++); |
There was a problem hiding this comment.
同じ名前のアニメーションは hoge hoge2 hoge3 ... となる
| { | ||
| var gltfAnimation = GLTF.animations[i]; | ||
| AnimationClip clip = default; | ||
| if (_externalObjectMap.TryGetValue(new SubAssetKey(typeof(AnimationClip), gltfAnimation.name), out UnityEngine.Object value)) |
There was a problem hiding this comment.
一応 SubAssetKey の中身に typeof(AnimationClip) を定義しておいたほうがいいかも（ホワイトリスト的な）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.