Improve linking support to (hopefully) all elements #2
Conversation
…ion-cascading Fix text decoration not cascading between children and parent
Export some libs to reduce the number of imports required
Add support for whitelisting tags
…into feature/improve-linking � Conflicts: � lib/flutter_html.dart
| @@ -434,10 +435,15 @@ class HtmlParser extends StatelessWidget { | |||
| ); | |||
| } else { | |||
| ///[tree] is an inline element. | |||
| return TextSpan( | |||
There was a problem hiding this comment.
This is breaking as you are not staying in 'span-land' but are using a widget, which potentially breaks line-wrapping.
There was a problem hiding this comment.
Yep I considered this. When I made this change the example app rendered fine so I decided to go ahead and push it.
This was necessary for supporting elements like <span>, <code>, <q>, etc because they don't meet any of the other criteria for other elements in the parseTree function.
The tags like <code> still displayed inline with this change. Do you know of a good way to test the inline flow? I know you worked with this type of issue with the links, so maybe a similar test process could help determine whether this is indeed an issue.
There was a problem hiding this comment.
Yeah this is indeed an issue as I suspected. This is how it should look like:
But with your code it looks like:
As the <span> I used (to make the background yellow) is now a separate widget instead of an inline span.
I revered this change but left your other contributions.
I used this test html:
<p>Lorem ipsum dolor amet, <span>consectetur adipiscing</span> elit, <a href="#bottom"><span>sed do eiusmod tempor</span> incididunt</a> ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
Title.
Adds support for the elements that weren't working as noted in my review on Sub6Resources#555
Also merged branch with master.