Changed vsgconv to handle missing output_filename argument #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameter was specified. If that was not the case the program will quit with an appropriate error message. This commit fixes vsg-dev#158
|
I have moved the check to before the outputFilename is assigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vsgconv tool would fail with a confusing error message if the caller failed to specify the output_filename.
This commit adds a check for the required minimum number of argument before starting to actually parse the input arguments using the ReaderWriters and quits, emitting an appropriate error message, if that number of arguments was not specified.
Fixes #158