Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set image registry and repository #298

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Set image registry and repository #298

merged 1 commit into from
Jan 28, 2025

Conversation

zugao
Copy link
Collaborator

@zugao zugao commented Jan 17, 2025

Summary

  • We have to make sure we can configure registries and repositories for our helm charts in the component. We might want to change the default docker hub registry.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@zugao zugao added the minor label Jan 17, 2025
@vshnbot vshnbot mentioned this pull request Jan 17, 2025
Merged
3 tasks
@zugao zugao force-pushed the update-appuio-registry branch from 9cef0f9 to 60ef76f Compare January 17, 2025 11:08
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team January 17, 2025 12:56
@zugao zugao force-pushed the update-appuio-registry branch from 60ef76f to b1ecaca Compare January 17, 2025 13:02
@zugao zugao requested a review from Kidswiss January 21, 2025 16:14
@wejdross wejdross merged commit 8c30e7c into master Jan 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wejdross wejdross wejdross approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zugao @Kidswiss @wejdross