Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HA alert rules docs #107

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Added HA alert rules docs #107

merged 2 commits into from
Jul 19, 2024

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Jul 19, 2024 •
edited
Loading

Summary

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@zugao zugao added the change label Jul 19, 2024
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team July 19, 2024 10:40
wejdross
wejdross approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's ok. It will probably expand with actual alerts firing

@zugao zugao merged commit 1c70b67 into master Jul 19, 2024
1 check passed
@zugao zugao deleted the ha-alerts-docs branch July 19, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wejdross wejdross wejdross approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss Kidswiss was automatically assigned from vshn/schedar

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zugao @wejdross