-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quality requirements for AppCat #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a good starting point 👍
This PR has gotten very large and I didn't fully review it yet.
Might consider splitting it up in some way.
Reading through it could roughly group the requirements into 2 categories:
- The ones targeting the AppCat as a Framework itself to establish a base standard. (e.g. some in usability or regarding monitoring)
- The ones that are try to dictate how services themselves should behave or be engineered. (e.g. security, performance)
I think it's better to only list the ones directly applicable for the framework. And then each service should be treated independently including things like security or performance aspects.
I feel these discussions are somewhat inefficient but very important. Let's make a call to discuss the details and then do some pair programming to get this done. |
5a38616
to
78834d6
Compare
I've rephrased the points that were still open. We can take that as a starting point for a call. |
@Kidswiss and I had a call to flesh out duplicates and things that are better left documented in the future service development guide. This PR got smaller and more structured. |
Vale complains again
Adds various quality requirements to the AppCat Framework.
Format is inspired by https://github.com/appuio/appuio-io-docs/