Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decision on SLI for MinIO #87

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add decision on SLI for MinIO #87

merged 1 commit into from
Oct 23, 2023

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Oct 22, 2023

Summary

The SLI for MinIO is a bit different from what we have implemented so far for PostgreSQL and Redis. In this document I describe the issue, propose several solutions and I also choose the one that fits best.
We can discuss here whether the decision is fine or not. Then I will do changes or I will amend it.

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog

@zugao zugao added the decision A decision that changes the architecture label Oct 22, 2023
@zugao zugao force-pushed the minio-sli-decision branch 2 times, most recently from 65129d2 to 64b3547 Compare October 22, 2023 19:52
Copy link
Member

@TheBigLee TheBigLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao force-pushed the minio-sli-decision branch from 64b3547 to e402841 Compare October 23, 2023 08:04
@zugao zugao merged commit cb40ab1 into master Oct 23, 2023
1 check passed
@zugao zugao deleted the minio-sli-decision branch October 23, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision A decision that changes the architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants