-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exoscale and kubernetes support #9
Conversation
ef5dcfa
to
d29e1a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is weird with the logging configuration.
Most log calls use V(1)
or V(2)
, but the default seems to be running with 0
. It currently only prints errors. Also the log-level
flag isn't actually used, but there's a debug
flag in the code that can't be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I spotted all the locations, but I suggest you have a look at error handling again
cc05a53
to
749c034
Compare
b63a0e2
to
5ddd908
Compare
5ddd908
to
f97762b
Compare
Summary
This PR is configured to be merged into invoice branch which means it's easier to review what changes have been done to the latest version of this POC. Ultimately this PR will be merged into master.
Test:
server=token
as you want.Later:
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog