-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement operator as a Crossplane provider #20
Conversation
a20d712
to
b071444
Compare
b071444
to
4e52ad4
Compare
4e52ad4
to
03541d8
Compare
03541d8
to
cc39a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly, in the next PR we will be able to install the provider with a Provider CRD manifest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few things to @zugao comments.
The rest LGTM.
8716c4b
to
0c90020
Compare
0c90020
to
ef80256
Compare
I've addressed your comments and amended some changes. |
This should avoid some confusion and duplication of a secret reference.
ef80256
to
a214991
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
20577a9
to
bf6b19b
Compare
Also, we need to store the intermediate results in the context, as the connector instance only exists once.
bf6b19b
to
5a8d7bb
Compare
Summary
managed.ExternalClient
, which follows the CRUD paradigm.CLOUDSCALE_API_TOKEN
env var was global to the operator container. This is now moved to aProviderConfig
and read from a secret referenced in there.ObjectsUser
CRD:displayName
. This can now be configured, but defaults to metadata.name if not given. Previously, it was hard set to{{ namespace.name }}
but now the CRDs aren't namespace scoped anymore.ObjectsUser
CRD:tags
. cloudscale.ch's API allows settings key-value tags. NOTE: They aren't visible currently in control.cloudscale.ch, only visible via API retrieval.The reason for this is that we at VSHN want to provide services for Application Catalog using Crossplane compositions.
See also #21
Checklist
For Code changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
area:operator
I have not made any changes in theChanges are done to make installations work with current state, but Helm chart is bound to be removed later.charts/
directory.