Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install provider via Crossplane as a package in local dev environment #26

Merged
merged 6 commits into from
Jul 29, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jul 28, 2022

Summary

  • This PR gets rid of the Helm chart and installs the provider as a Crossplane package instead
  • Seeing how Crossplane packages work and their installation, a local registry is required to avoid having to push a temporary image to a public registry just for testing.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues

@ccremer ccremer added the change Generic change that is neither a fix or feature label Jul 28, 2022
@ccremer ccremer marked this pull request as ready for review July 28, 2022 14:50
@ccremer ccremer requested review from Kidswiss and zugao July 28, 2022 14:55
@ccremer
Copy link
Contributor Author

ccremer commented Jul 28, 2022

For testing this PR:
Follow the quickstart section in the readme and inspect the results

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the package fails for me with a linting error:

gmake package-provider
kubectl crossplane: error: failed to build package: failed to lint package: not exactly one package meta type
gmake: *** [package/package.mk:20: package-provider] Error 1

EDIT: renaming crossplane.yaml.template to crossplane.yaml fixes the issue. I guess something is supposed to transform the template file?

operator/bucketcontroller/setup.go Show resolved Hide resolved
@zugao
Copy link
Contributor

zugao commented Jul 29, 2022

Having the same issue as @Kidswiss:
kubectl crossplane: error: failed to build package: failed to lint package: not exactly one package meta type

@ccremer
Copy link
Contributor Author

ccremer commented Jul 29, 2022

I've fixed the package generation. you're invited to test again

@ccremer ccremer requested a review from Kidswiss July 29, 2022 08:03
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working now.

@ccremer ccremer merged commit e99a099 into master Jul 29, 2022
@ccremer ccremer deleted the local-package branch July 29, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Generic change that is neither a fix or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants