-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize tooling around local dev environment #32
Conversation
This should make installing the tools required for local development easier. The only thing we lose is having them versioned to a specific tag. We've been using these tools for quite some time now and there are rarely issues than can be pointed to specific versions. By running 'make clean', these tools get uninstalled, upon next time they're needed they get downloaded and updated again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have so many targets for cleaning in so many files? I would go with just one target where you clean everything in one place.
I went for a more modular approach where it's more understandable why which files get to be cleaned. |
@zugao I like the approach, this way you can clean individual tools, if you have issues with them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installation of kind doesn't seem to work on my system from within the make file.
I think I would actually prefer to keep the old tooling method.
|
I can understand why you want the old method. However, as pointed out in the PR description, since a year or so I've never experienced issues with tooling versions. By having them installed with We could consider setting |
Yeah, I think this would be a good compromise. |
TIL: This is how to create directories in make if it doesn't exist:
(note the pipe) |
Looks like the hardcoding of
Adding:
Seems to fix things. |
To avoid version conflicts of other projects.
Darn, forgot about that. I've re-added the env vars |
Summary
This should make installing the tools required for local development easier.
The only thing we lose is having them versioned to a specific tag.
We've been using these tools for quite some time now and there are rarely issues than can be pointed to specific versions.
By running 'make clean', these tools get uninstalled, upon next time they're needed they get downloaded and updated again.
Checklist
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelog
make test-e2e
and e2e tests pass successfully