Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PR checklist #66

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Extend PR checklist #66

merged 1 commit into from
Jan 20, 2023

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jan 20, 2023

This will adjust the checklist in the PR template to contain more context and expectations how a PR should be presented before it's review ready.

As discussed in vshn/component-appcat#77

Checklist

  • PR contains a single logical change (to keep release notes relevant)
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Link this PR to related issues
  • I have run make test-e2e and e2e tests pass successfully

This will adjust the checklist in the PR template to contain more
context and expectations how a PR should be presented before it's review
ready.

As discussed in vshn/component-appcat#77
@Kidswiss Kidswiss added the documentation Improvements or additions to documentation label Jan 20, 2023
@Kidswiss Kidswiss merged commit ba53c61 into master Jan 20, 2023
@Kidswiss Kidswiss deleted the change/pr_template branch January 20, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant