Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in node state mapping #61

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Fix panic in node state mapping #61

merged 1 commit into from
Nov 24, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Nov 24, 2022

Summary

Node states are not guaranteed to have a state. For example Kafka nodes don't. In any case we should never panic in the node state mapping

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • I have run make test-e2e and e2e tests pass successfully

@glrf glrf added the bug Something isn't working label Nov 24, 2022
@glrf glrf self-assigned this Nov 24, 2022
@glrf glrf marked this pull request as ready for review November 24, 2022 14:53
@glrf glrf requested review from zugao and mweibel November 24, 2022 14:54
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glrf glrf merged commit c827a48 into master Nov 24, 2022
@glrf glrf deleted the fix/mapper-panic branch November 24, 2022 16:44
@glrf glrf mentioned this pull request Dec 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants