Fix reconcile loop for DBaaS with reported default settings #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glrf
force-pushed
the
fix/default-settings
branch
4 times, most recently
from
6fb78e4
to
1a0c190
Compare
glrf
force-pushed
the
fix/default-settings
branch
from
1a0c190
to
778cca5
Compare
glrf
force-pushed
the
fix/default-settings
branch
from
778cca5
to
0854bdd
Compare
|
Code change looks fine, tests are passing, I can't see issue anymore in logs. For me: LGTM |
zugao
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exoscale reports defaults settings when creating a DBaaS with empty settings. This means, when a new instance is created an infinite loop of updates are triggered as the managed resource settings never matches with the settings from upstream.
This PR fixes this by first fetching the setting schemas, extracting the defaults from it, and including it when calculating the diff.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.