Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control-clicking translations list messes up selection on macOS #849

Closed
vslavik opened this issue Jul 4, 2024 · 0 comments · Fixed by wxWidgets/wxWidgets#24697
Closed

Control-clicking translations list messes up selection on macOS #849

vslavik opened this issue Jul 4, 2024 · 0 comments · Fixed by wxWidgets/wxWidgets#24697
Labels
macOS

Comments

@vslavik
Copy link
Owner

vslavik commented Jul 4, 2024

Steps to reproduce:

  1. Show context menu on the list by pressing control and clicking with mouse.
  2. Do not select any item in the popup menu, click outside of the menu, on the list, to dismiss the menu.
  3. Try moving selection to another item in the list and observe totally bizarre selection behavior.

Words fails me trying to describe step 3 accurately, so here's a video recorded by a user who reported the bug:

poedit_selection.mov
@vslavik vslavik added the macOS label Jul 4, 2024
vslavik added a commit to vslavik/wxWidgets that referenced this issue Jul 12, 2024
@vslavik
Don't use menuForEvent: in wxDataViewCtrl on macOS
f370e9e 
Returning nil from menuForEvent: and then popping up a menu manually
causes some kind of Cocoa internal state confusion if the right-click
was performed by holding down Control and clicking (as is the Mac
alternative to right-click). See vslavik/poedit#849

Implement wxEVT_DATAVIEW_ITEM_CONTEXT_MENU event using a handler for
the regular wxEVT_CONTEXT_MENU event instead.
@vslavik vslavik mentioned this issue Jul 12, 2024
Merged
@vslavik vslavik closed this as completed in 79c9cf0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to context menus in wxDVC on macOS vslavik/wxWidgets
1 participant
@vslavik