-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing Error messages refactor #331
base: master
Are you sure you want to change the base?
Conversation
Good news: with the latest changes to our tooling, messages like I would suggest keeping most of the changes in this PR with the exception of the code that handles locations after error text (it can be safely removed). I would also prefer to go back to the previous signature of Parse... methods (have them return Message or null). I think it's a good style to keep functions pure by avoiding in-out parameters where it's possible. |
…ultiple locations error as well as errors with location after message in general
Thanks! Is 9fd8cb2 works for you? |
This PR provides some code refactor for Error messages parsing logic.
Notable change: we do not handle error formats in which location are mentioned after error text.