-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHK-134: Drop-down field style of Location Search autocomplete component #21
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1ed6afd
Add popover style and decouple component
wdsrocha 965707d
Add list style
wdsrocha 77ae1f5
Add kind of broken Option
wdsrocha cb9a8c2
Fix popover style
wdsrocha 1b57356
Fix option alignment a little bit
wdsrocha afa5148
Put drop-down in the right place
wdsrocha a643966
Use symetric padding on Option and fix icon shrink
wdsrocha fe3e4fa
Add styling on msg displayed when the search fails
wdsrocha 3bc5d5c
Remove redundant truncate and make fail msg grey
wdsrocha dae152f
Add big addresses so we can test text overflow
wdsrocha 1e11bbe
Shortnen spanish text so it fits the component (gracias Maxito 🇦🇷)
wdsrocha 88b062b
Add Option bg color on hover
wdsrocha 7127d88
Add mocked Google logo
wdsrocha abe1326
Add prop for engine logo
wdsrocha a013635
Refactor ref variable name
wdsrocha 72e205d
Document why we clear button isn't tabbable
wdsrocha 5156127
Stop sending props to renderEngineLogo
wdsrocha d2c3da5
Decouple Place Icon from Combobox component
wdsrocha 4b3edac
Pass Place Icon as prop instead of render function
wdsrocha 80b5967
Add complexity to mocked addresses
wdsrocha bb0ae9d
Add extra data and highlight to suggestion
wdsrocha c562b3b
Decouple data fetching logic from the component
wdsrocha 3ad803d
Fix Place Icon color
wdsrocha 734f0fc
Fix clear icon color on hover
wdsrocha e44fe25
Fix option color when active
wdsrocha e1fdd9a
Fix color and text width from search failure
wdsrocha 656efdc
Increase Clear button clickable area
wdsrocha a2caaa2
Let component width be handled by parent
wdsrocha 9823bf7
Simplify renderSuggestionText
wdsrocha 94ba39f
Remove unused abstraction
wdsrocha 2c1428d
Use styling from Tachyons
wdsrocha 0bfa9b3
Refactor nit
wdsrocha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the text inside an Option is too big, it will truncate with an ellipsis, but there is a problem: the
mainText
(street name) is black and thesecondaryText
(city and state name) is gray, which would require the ellipsis color to be dynamic, depending on which part have overflowed.Doing this at implementation level is quite painful and don't seems to bring too much value (big street names aren't very common, I guess), so I've opted to always display the ellipsis with a gray color. Is that okay? @davicosta99 @augustocb
Example of fake big street name with the grey colored ellipsis:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine, Wesley, thanks for the concern. Appreciate the level of care 😉