Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call IS instead of Solr for PDP query ✨ #468

Open
wants to merge 4 commits into
base: v1.x
Choose a base branch
from

Conversation

thalytafabrine
Copy link
Member

@thalytafabrine thalytafabrine commented Mar 12, 2024

How should this be manually tested?

You can compare the results between the production query and the workspace query
canali - prod
canali - dev
pdp

image image

arcaplanet - prod
arcaplanet - dev

image image

if you want to test translations, you can change the locale on your segment cookie and call the query again.
ex. for canali:
image

Type of changes

✔️ Type of Change
_ Bug fix
✔️ New feature
_ Breaking change
_ Technical improvements

Notes

@thalytafabrine thalytafabrine self-assigned this Mar 12, 2024
Copy link

vtex-io-ci-cd bot commented Mar 12, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 12, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

node/resolvers/search/offer.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants