Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add groupBy prop in recommendation shelf #282

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

iago1501
Copy link
Contributor

What problem is this solving?

We have a limitation in Recommendation queries where we always group by products, but, some customers, especially when talking about fashion segments, want to show also individual SKUs instead, this feature is responsible for allowing that.

Also, there's another limitation presented here that we are trying to cover. When grouping by products and calling the catalog cross selling API, we do a reduced search, in this reduced search, the total quantity of products returned is limited by 12, but, if we don't use this parameter the limit is 50, so, we are also increasing the possibility of the number of products returned by this query

How to test it?

Workspace
Site Editor

Add the block shelf.relatedProducts with the prop groupBy

  "shelf.relatedProducts": {
    "blocks": ["product-summary.shelf"],
    "props": {
      "recommendation": "similars",
      "groupBy": "NONE"
    }    
  },
image

Describe alternatives you've considered, if any.

Related to / Depends on

vtex-apps/search-resolver#467
vtex-apps/search-graphql#135

@iago1501 iago1501 self-assigned this Mar 11, 2024
@iago1501 iago1501 requested a review from a team as a code owner March 11, 2024 17:04
@iago1501 iago1501 requested review from icazevedo, lariciamota and RodrigoTadeuF and removed request for a team March 11, 2024 17:04
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@iago1501 iago1501 requested review from a team as code owners March 11, 2024 17:19
@iago1501 iago1501 requested review from julia-rabello and removed request for a team March 11, 2024 17:19
@iago1501 iago1501 merged commit d62ab5a into master Mar 21, 2024
6 checks passed
@iago1501 iago1501 deleted the feat/groupByCrossSelling branch March 21, 2024 16:22
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 21, 2024

Your PR has been merged! App is being published. 🚀
Version 1.47.4 → 1.48.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.shelf@1.48.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants