-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix / prohibit the use of old ABTester versions #12
Conversation
94a0f9c
to
0de7c4e
Compare
This last test keeps timing out :kaotico: |
Seems to be common :harold-pain: yarnpkg/yarn#8242 |
0de7c4e
to
eefb2c7
Compare
Just tried again, and it worked! 🎉 :watt: |
Please lint your project and commit again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the disclaimer that I didn't test the plugin nor have enough context about the removals on promptSignificanceLevel
|
What is the purpose of this pull request?
To prevent the user from using old versions of the ABTester.
What problem is this solving?
Some old versions of
vtex.ab-tester
haven't been working properly.Also, this change will simplify the cli's code.
Types of changes
Chores checklist
CHANGELOG.md