feat(api): Handle channel as facet for search and product queries #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5c5529f:
|
igorbrasileiro
force-pushed
the
feat/regionid-as-facet-vtex
branch
from
c6ae613
to
ccd0ee9
Compare
tlgimenes
reviewed
Mar 30, 2022
|
|
||
| export const Query = { | ||
| product: async (_: unknown, { locator }: QueryProductArgs, ctx: Context) => { | ||
| // Insert channel in context for later usage | ||
| ctx.storage = { | ||
| ...ctx.storage, | ||
| channel: | ||
| locator.find((facet) => facet.key === 'channel')?.value ?? | ||
| ctx.storage.channel, | ||
| // TODO: Check if make sense move this parse a layer down or pass the whole parsed channel |
There was a problem hiding this comment.
just keep it like a string
There was a problem hiding this comment.
So, you mean that should maintain as a string here and move the parse to be done inside a lower layer?
There was a problem hiding this comment.
Keep like a string breaks some internal field resolvers take a look at the
https://sfj-a1d5edd--base.preview.vtex.app/office/
ERROR
Error: Product with id 2791588 has no sellers for channel
{"regionId":"v2.1BB18CE648B5111D0933734ED83EC783","salesChannel":"1"}.
at Object.offers
(webpack://base.store/./node_modules/@faststore/api/dist/api.esm.js?:820:13)
at Object.field.resolve [as StoreProductoffersResolver]
(webpack://base.store/./node_modules/@envelop/core/index.js?:86:32)
at nodeStoreProductEdgenodeResolverHandler (eval at compileQuery
(webpack://base.store/./node_modules/graphql-jit/dist/execution.js?), <anonymous>:3012:39)
at StoreProductConnection__fieldedgesMapItemHandler.__value.then.__context.nullErrors.push._
_context.GraphQLError.line (eval at compileQuery
(webpack://base.store/./node_modules/graphql-jit/dist/execution.js?), <anonymous>:3151:9)
at runMicrotasks (<anonymous>)
at processTicksAndRejections (internal/process/task_queues.js:95:5) {
locations: [ { line: 32, column: 11 } ],
path: [ 'search', 'products', 'edges', 0, 'node', 'offers' ]
}
tlgimenes
reviewed
Mar 30, 2022
tlgimenes
reviewed
Mar 30, 2022
igorbrasileiro
force-pushed
the
feat/regionid-as-facet-vtex
branch
from
1b1243b
to
447a842
Compare
igorbrasileiro
changed the title
tlgimenes
approved these changes
Mar 30, 2022
|
Desconsider problems with ci/test frompull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
How it works?
How to test it?
base.storeDeploy Previewvtex-sites/base.store#428
References