fix: fix dropdown menu position with scroll #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 511453e:
|
ArthurTriis1
force-pushed
the
fix/fix-dropdown-position-with-scroll-bug
branch
from
ea218d7
to
6d738de
Compare
hellofanny
changed the title
hellofanny
changed the title
heitorado
reviewed
Mar 30, 2022
packages/ui/src/molecules/Dropdown/hooks/useDropdownPosition.ts
Outdated
Show resolved
Hide resolved
igorbrasileiro
suggested changes
Mar 30, 2022
ArthurTriis1
force-pushed
the
fix/fix-dropdown-position-with-scroll-bug
branch
from
5f03a15
to
8f4729a
Compare
igorbrasileiro
approved these changes
Mar 31, 2022
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
Signed-off-by: Arthur Andrade <arthurfelandrade@gmail.com>
ArthurTriis1
force-pushed
the
fix/fix-dropdown-position-with-scroll-bug
branch
from
8f4729a
to
511453e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arthur Andrade arthurfelandrade@gmail.com
What's the purpose of this pull request?
This PR fix bugs with scroll on Dropdown component. It adds the properties
scrollLeftandscrollTopto calculate of position, and addsevent.preventDefault()inKeyDownpress event, avoiding page scroll when pressed.References
https://stackoverflow.com/a/18673641