-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turborepo #1296
Merged
Merged
Turborepo #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2c8a53d
to
c515b87
Compare
igorbrasileiro
approved these changes
May 13, 2022
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19e3b42:
|
tlgimenes
approved these changes
May 30, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since lerna died, this PR is intended to use turborepo.
For now, we're using turborepo + lerna; The first is responsible for task runner and the last is responsible for publishing.
We will gradually make some changes:
@vtex/lighthouse-config
to@faststore/lighthouse
@vtex/theme-b2c-tailwind
to@faststore/theme
(best name suggestions are welcome)Results on Build time:
Using lerna
![Screen Shot 2022-05-13 at 15 02 53](https://user-images.githubusercontent.com/10627086/168341607-578a1098-7bff-4952-91af-9d557b07576e.png)
Using turborepo
![Screen Shot 2022-05-13 at 15 05 27](https://user-images.githubusercontent.com/10627086/168341902-707aed36-0908-4f25-b292-c19ffa51c338.png)
Using turborepo + cache
![Screen Shot 2022-05-13 at 15 05 55](https://user-images.githubusercontent.com/10627086/168341958-5fd5bedf-10e0-4996-87ef-1572b81de93a.png)